This repository was archived by the owner on Nov 7, 2025. It is now read-only.
Ingest stats panic - fix #1440
Merged
Ingest stats panic - fix #1440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying quesma with
|
| Latest commit: |
71bf37e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2403c996.quesma.pages.dev |
| Branch Preview URL: | https://ingest-stats-panic.quesma.pages.dev |
Member
Author
|
/run-it |
Contributor
There was a problem hiding this comment.
Pull Request Overview
The PR aims to fix a panic caused by concurrent map access by adjusting the mutex lock placement.
- Removed redundant lock from the internal process function.
- Added explicit locking in the Process and UpdateNonSchemaValues functions to protect shared map access.
Comments suppressed due to low confidence (1)
platform/stats/ingest_statistics.go:123
- Ensure that the updated locking strategy is consistently applied; verify that the process function is only invoked via the wrapper methods where the lock is acquired to prevent unintended concurrent access from elsewhere.
defer mu.Unlock()
|
|
||
| func (s *Statistics) Process(ingestStatsEnabled bool, index string, jsonData types.JSON, nestedSeparator string) { | ||
|
|
||
| mu.Lock() |
There was a problem hiding this comment.
[nitpick] Consider narrowing the scope of the mutex lock to only cover the critical map access operations to reduce potential contention if the process function performs heavy processing.
pdelewski
approved these changes
Jun 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes not protected concurrent map access.